Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make pre-commit hooks run on PR in core packages #565

Closed
benwandrew opened this issue Sep 1, 2023 · 3 comments
Closed

ci: Make pre-commit hooks run on PR in core packages #565

benwandrew opened this issue Sep 1, 2023 · 3 comments
Assignees
Labels
priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks.

Comments

@benwandrew
Copy link
Collaborator

Make pre-commit hooks run in "core" packages on PR, for example, in autora-synthetic. Use the example in https://github.com/AutoResearch/autora-core to do this.

@benwandrew benwandrew self-assigned this Sep 1, 2023
@benwandrew benwandrew added the priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks. label Sep 1, 2023
@benwandrew
Copy link
Collaborator Author

benwandrew commented Oct 18, 2023

this is not nearly as straightforward as i originally thought. i think it is going to require everyone's effort since i don't have the familiarity with individual modules to fix all errors after running the hooks... i have spent a decent amount of time spinning my wheels here without progress. perhaps the author of each module can add and run the hooks, and then resolve the resulting errors for their own modules?

eg. Joshua -- BMS, Star -- BSR, etc...

@musslick
Copy link
Collaborator

musslick commented Oct 25, 2023

  • remove mypy from core packages except ones where it already passes
  • for each package where mypy was remove, add an issue to add it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks.
Projects
None yet
Development

No branches or pull requests

6 participants