Remove sampler category #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesStrittmatter
requested review from
hollandjg,
musslick,
chadcwilliams and
benwandrew
benwandrew
reviewed
Sep 1, 2023
|
|
||
| The uncertainty sampler identifies experimental conditions $\vec{x}' \in X'$ with respect model uncertainty. Within the uncertainty sampler, there are three methods to determine uncertainty: | ||
| The uncertainty experimentalist identifies experimental conditions $\vec{x}' \in X'$ with respect model uncertainty. Within the uncertainty sampler, there are three methods to determine uncertainty: |
There was a problem hiding this comment.
looks like we need to change 'sampler' to 'experimentalist' in second sentence also, correct? also missing 'to' in 'with respect to model uncertainty'
benwandrew
reviewed
Sep 1, 2023
| @@ -1,4 +1,4 @@ | |||
| # Uncertainty Sampler | |||
| # Uncertainty Experimentalist | |||
|
|
|||
| The uncertainty sampler identifies experimental conditions $\vec{x}' \in X'$ with respect model uncertainty. Within the uncertainty sampler, there are three methods to determine uncertainty: | |||
There was a problem hiding this comment.
same here, need to update 'sampler'
benwandrew
reviewed
Sep 1, 2023
| @@ -1,6 +1,6 @@ | |||
| [project] | |||
| # UPDATE THIS BEFORE PUBLISHING | |||
| name = "autora-experimentalist-sampler-uncertainty" | |||
| name = "autora-experimentalist-uncertainty" | |||
| description = "Sampler based on where the model is least certain." | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove sampler category according to https://github.com/orgs/AutoResearch/projects/3/views/1?sliceBy%5BcolumnId%5D=Milestone&sliceBy%5Bvalue%5D=AutoRA+Release+for+Paper+Submission&pane=issue&itemId=35962296