chore: rename n to num_samples #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesStrittmatter
requested review from
hollandjg,
musslick,
chadcwilliams and
benwandrew
benwandrew
approved these changes
Jul 5, 2023
hollandjg
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Looks good to me!
Note: This is a breaking change for the interface, so will need to be a new major version of autora-experimentalist-sampler-uncertainty. I'd recommend changing the title of the PR to fix!: rename n to num_samples – the ! denotes a breaking change. I think it's actually more of a fix than a chore – it's fixing the consistency with other parts of the package, rather than repairing a typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.