Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aligned random pooler input arguments with those of grid pooler #15

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

musslick
Copy link
Contributor

@musslick musslick commented Jul 3, 2023

Description

The PR fixes #13 and #9. It aligns the input arguments from the random pooler and the grid pooler.

Type of change

Delete as appropriate:

  • fix: A bug fix

Features (Optional)

  • fixed input arguments
  • added test for random pooler

@musslick musslick added the enhancement New feature or request. label Jul 3, 2023
@musslick musslick self-assigned this Jul 3, 2023
@musslick musslick requested a review from benwandrew July 3, 2023 22:02
Copy link
Contributor

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@musslick musslick added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit 31d60d9 Jul 6, 2023
hollandjg added a commit that referenced this pull request Nov 29, 2023
…s-of-workflow-need-to-be-renamed-form-observationsdvsivs-to-observationsconditionsobservations

refactor: rename from observations.dvs/ivs to data.conditions/observations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
3 participants