Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid pooler and random pooler expect different arguments #9

Closed
younesStrittmatter opened this issue Jun 7, 2023 · 0 comments · Fixed by #33 · May be fixed by #92
Closed

grid pooler and random pooler expect different arguments #9

younesStrittmatter opened this issue Jun 7, 2023 · 0 comments · Fixed by #33 · May be fixed by #92
Labels
enhancement New feature or request.

Comments

@younesStrittmatter
Copy link
Contributor

The grid pooler expects a list of IVs (or at least variables) as input, while the random pooler expects a list of discrete values. It might be worth making this consistent.
@musslick musslick mentioned this issue Jul 3, 2023
Merged
This was referenced Jul 7, 2023
Closed
Closed
@hollandjg hollandjg added the enhancement New feature or request. label Jul 7, 2023
@hollandjg hollandjg mentioned this issue Jul 18, 2023
Merged
@hollandjg hollandjg linked a pull request Jul 18, 2023 that will close this issue
feat!: update experimentalists grid_pool, random_pool, random_sample to use the new State mechanism #33
Merged
hollandjg added a commit that referenced this issue Nov 29, 2023
@hollandjg
Merge pull request #9 from AutoResearch/chore-remove-ide-directory
9500870 
chore: remove IDE files
@younesStrittmatter younesStrittmatter mentioned this issue Aug 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request.
Projects
None yet
Milestone
No milestone
2 participants
@hollandjg @younesStrittmatter