-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run poetry lock and reinstall everything with pip #20
base: main
Are you sure you want to change the base?
Conversation
Draft because AstarVienna/ScopeSim#503 should first be merged, and then the slack bot should be turned on again. But conceptually this is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, all the pip install -e <pkg>
at the end are probably the best way to solve this now. That's what I have been doing locally anyway when testing if e.g. a change in ScopeSim would break an IRDB notebook. That is, have the local feature branch with that change checked out and running pip install -e
, then run the notebooks.
Now, the question is, why do we still need the poetry commands in this script at all??
Because it is not possible to install the dependency groups without poetry.. See https://stackoverflow.com/questions/76118614/is-it-possible-to-install-poetry-groups-with-pip But that page links to https://discuss.python.org/t/-/39233 and that links to https://peps.python.org/pep-0735/ "Dependency Groups in pyproject.toml", which is marked as Accepted, so maybe there will be a better way to get those dependency groups in soon |
Ah right, I remember we've been there...
Looks useful, ideally poetry would incorporate that once it's actually a thing, then we would get the best of both worlds... |
This should prevent ScopeSim_Data from downgrading scopesim to 0.9.0 or whatever all the time.