Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore strip_cdata warning by lxml, introduced by bs4 #504

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

hugobuddel
Copy link
Collaborator

Should be fixed in beautifulsoup 4.13

I'm just going to merge this though, to see how far AstarVienna/ScopeSim_Data#20 comes without having to explicitly specify branches and such.

Should be fixed in beautifulsoup 4.13
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (f1a140f) to head (98e59a9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   77.19%   77.19%           
=======================================
  Files          66       66           
  Lines        8209     8209           
=======================================
  Hits         6337     6337           
  Misses       1872     1872           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugobuddel hugobuddel merged commit a2d22f2 into main Nov 17, 2024
20 of 22 checks passed
@hugobuddel hugobuddel deleted the hb/ignore_strip_cdata branch November 17, 2024 11:36
Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants