feat: propagate error status codes to parent spans for improved visibility into trace exceptions #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axiomofjoy
changed the title
RogerHYang
approved these changes
Nov 29, 2023
RogerHYang
reviewed
Nov 29, 2023
mikeldking
reviewed
Nov 30, 2023
mikeldking
reviewed
Nov 30, 2023
mikeldking
approved these changes
Nov 30, 2023
RogerHYang
reviewed
Nov 30, 2023
RogerHYang
reviewed
Nov 30, 2023
RogerHYang
reviewed
Nov 30, 2023
mikeldking
pushed a commit
that referenced
this pull request
Dec 1, 2023
…ility into trace exceptions (#1824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Visibility Into Trace Exceptions by Propagating Error Status Codes to Parent Spans
Overview
Previously, error status codes on children spans were not propagated upward to parent spans in the UI. This caused a usability issue where users could not identify traces that contained exceptions without exploding the traces into their constituent spans.
This PR adds a new field
propagatedStatusCodeto theSpanGraphQL model that propagates errors from descendants to ancestors. This field is computed on the fly in a similar manner to the accumulated token counts.Before and After
Collapsed Traces
Before
After
Exploded Traces
Before
After
Tree
Before
After