Skip to content

Commit

Permalink
feat: propagate error status codes to parent spans for improved visib…
Browse files Browse the repository at this point in the history
…ility into trace exceptions (#1824)
  • Loading branch information
axiomofjoy authored Nov 30, 2023
1 parent 94442a9 commit 1a234e9
Show file tree
Hide file tree
Showing 9 changed files with 96 additions and 67 deletions.
5 changes: 5 additions & 0 deletions app/schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,11 @@ type Span {
"""
cumulativeTokenCountCompletion: Int

"""
Propagated status code that percolates up error status codes from descendant spans (children, grandchildren, etc.)
"""
propagatedStatusCode: SpanStatusCode!

"""
Evaluations associated with the span, e.g. if the span is an LLM, an evaluation may assess the helpfulness of its response with respect to its input.
"""
Expand Down
2 changes: 1 addition & 1 deletion app/src/pages/trace/TracePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export function TracePage() {
}
name
spanKind
statusCode
statusCode: propagatedStatusCode
startTime
parentId
latencyMs
Expand Down
12 changes: 6 additions & 6 deletions app/src/pages/trace/__generated__/TracePageQuery.graphql.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions app/src/pages/tracing/TracesTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export function TracesTable(props: TracesTableProps) {
rootSpan: node {
spanKind
name
statusCode
statusCode: propagatedStatusCode
startTime
latencyMs
tokenCountTotal: cumulativeTokenCountTotal
Expand All @@ -144,7 +144,7 @@ export function TracesTable(props: TracesTableProps) {
descendants {
spanKind
name
statusCode
statusCode: propagatedStatusCode
startTime
latencyMs
parentId
Expand Down
12 changes: 6 additions & 6 deletions app/src/pages/tracing/__generated__/TracesTableQuery.graphql.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1a234e9

Please sign in to comment.