Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: propagate error status codes to parent spans for improved visibility into trace exceptions #1824

Merged
merged 21 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,11 @@ type Span {
"""
cumulativeTokenCountCompletion: Int

"""
Propagated status code that percolates up error status codes from descendant spans (children, grandchildren, etc.)
"""
propagatedStatusCode: SpanStatusCode!

"""
Evaluations associated with the span, e.g. if the span is an LLM, an evaluation may assess the helpfulness of its response with respect to its input.
"""
Expand Down
2 changes: 1 addition & 1 deletion app/src/pages/trace/TracePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export function TracePage() {
}
name
spanKind
statusCode
statusCode: propagatedStatusCode
startTime
parentId
latencyMs
Expand Down
12 changes: 6 additions & 6 deletions app/src/pages/trace/__generated__/TracePageQuery.graphql.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions app/src/pages/tracing/TracesTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export function TracesTable(props: TracesTableProps) {
rootSpan: node {
spanKind
name
statusCode
statusCode: propagatedStatusCode
startTime
latencyMs
tokenCountTotal: cumulativeTokenCountTotal
Expand All @@ -144,7 +144,7 @@ export function TracesTable(props: TracesTableProps) {
descendants {
spanKind
name
statusCode
statusCode: propagatedStatusCode
startTime
latencyMs
parentId
Expand Down
12 changes: 6 additions & 6 deletions app/src/pages/tracing/__generated__/TracesTableQuery.graphql.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading