Core: move OptionGroup definition to Options.py
#3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
This was referenced May 18, 2024
Merged
|
Seems like a sensible change. If this is going to happen, now is the time, before a bunch of worlds use this feature. |
PoryGone
approved these changes
May 18, 2024
alwaysintreble
suggested changes
May 18, 2024
Co-authored-by: Aaron Wagener <[email protected]>
Exempt-Medic
approved these changes
May 18, 2024
Exempt-Medic
added
waiting-on: core-review
alwaysintreble
approved these changes
May 19, 2024
Berserker66
approved these changes
May 19, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
BaseClasses.pydoesn't seem like the right place for this.BaseClasses.pywas otherwise untouched by the PR that introduced this featureOptionGroups in their world's options module, which often doesn't import anything else fromBaseClasses.pyBaseClassesto those imports increases the risk of having to deal with circular import issues.How was this tested?
opened an option page from WebHost, observed the option groups, generated a game from the option page