Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Celeste 64: Option Groups #3321

Merged
merged 3 commits into from
May 21, 2024
Merged

Celeste 64: Option Groups #3321

merged 3 commits into from
May 21, 2024

Conversation

PoryGone
Copy link
Collaborator

What is this fixing or adding?

Option Groups for Celeste 64

How was this tested?

I ran the WebHost and see the Option Groups.
I generated template YAMLs from the launcher and saw the group headers.

If this makes graphical changes, please attach screenshots.

image

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 18, 2024
@beauxq
Copy link
Collaborator

beauxq commented May 18, 2024

keep an eye on this: #3325
(especially since unit tests might not catch worlds failing to load because of a moved import)

@Exempt-Medic Exempt-Medic added the is: refactor/cleanup Improvements to code/output readability or organizization. label May 19, 2024
beauxq
beauxq approved these changes May 19, 2024
View reviewed changes
Copy link
Collaborator

@beauxq beauxq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. and removed is: refactor/cleanup Improvements to code/output readability or organizization. labels May 19, 2024
@PoryGone PoryGone added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 19, 2024
@LegendaryLinux LegendaryLinux merged commit 20134d3 into ArchipelagoMW:main May 21, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@PoryGone
Celeste 64: Option Groups (ArchipelagoMW#3321)
73e92f9 
* Celeste 64: Option Groups

* Retarget OptionGroup import
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@PoryGone @sflavelle
Celeste 64: Option Groups (ArchipelagoMW#3321)
44f4929 
* Celeste 64: Option Groups

* Retarget OptionGroup import
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@PoryGone @qwint
Celeste 64: Option Groups (ArchipelagoMW#3321)
15f8ad1 
* Celeste 64: Option Groups

* Retarget OptionGroup import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegendaryLinux LegendaryLinux LegendaryLinux approved these changes

@beauxq beauxq beauxq approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PoryGone @beauxq @LegendaryLinux @Exempt-Medic