Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][doc] Update docs for Partition increase command #1

Closed
wants to merge 1 commit into from

Conversation

Apurva007
Copy link
Owner

Fixes apache#17878

Motivation

The Pulsar documentation currently states that partition update works only for non-global topics. This statement seems to be incorrect as per the below PR:
apache#5306

Modifications

Updated the code comments as well as modified the API documentation for the swagger generation.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@Apurva007 Apurva007 changed the title [Fix][Doc] Update docs for Partition increase command [fix][Doc] Update docs for Partition increase command Apr 5, 2023
@Apurva007 Apurva007 changed the title [fix][Doc] Update docs for Partition increase command [fix][doc] Update docs for Partition increase command Apr 5, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8c50a6c). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   72.84%           
  Complexity        ?    31497           
=========================================
  Files             ?     1861           
  Lines             ?   137290           
  Branches          ?    15118           
=========================================
  Hits              ?   100014           
  Misses            ?    29324           
  Partials          ?     7952           
Flag Coverage Δ
inttests 24.40% <0.00%> (?)
systests 24.93% <0.00%> (?)
unittests 72.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Apurva007 Apurva007 closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Fix Admin Interface docs for Managing partitioned topics
2 participants