Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix Admin Interface docs for Managing partitioned topics #17878

Closed
2 tasks done
Tracked by #17495
Apurva007 opened this issue Sep 28, 2022 · 15 comments · Fixed by apache/pulsar-site#473 or #20035
Closed
2 tasks done
Tracked by #17495

[Doc] Fix Admin Interface docs for Managing partitioned topics #17878

Apurva007 opened this issue Sep 28, 2022 · 15 comments · Fixed by apache/pulsar-site#473 or #20035
Assignees
@Apurva007
Labels
doc-required Your PR changes impact docs and you will update later. good first issue Good for newcomers

Comments

@Apurva007
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

What issue do you find in Pulsar docs?

The pulsar docs for updating partitioned topics states that it works only for non-global topics. This seems to be incorrect as per the below pull request:
#5306

What is your suggestion?

Please can we remove this statement from the explanation provided for the Update Partitioned topic piece:
"if the topic is non-global"

Any reference?

https://pulsar.apache.org/docs/next/admin-api-topics/#update

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@Apurva007 Apurva007 added the doc-required Your PR changes impact docs and you will update later. label Sep 28, 2022
@tisonkun tisonkun mentioned this issue Sep 29, 2022
Closed
17 tasks
@sijie sijie mentioned this issue Sep 29, 2022
Open
2 tasks
@momo-jun
Copy link
Contributor

@liangyepianzhou can you pls help double-check the issue from a technical accuracy perspective?

@momo-jun
Copy link
Contributor

@Apurva007 welcome to the Pulsar community. It's a good first issue. Would you like to fix it?

@momo-jun momo-jun added the good first issue Good for newcomers label Sep 29, 2022
@Apurva007
Copy link
Contributor Author

@momo-jun Thanks alot! I was trying to learn about Apache Pulsar and stumbled upon this issue. I would gladly help fix this issue. 😄

@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Oct 30, 2022
@tisonkun
Copy link
Member

tisonkun commented Dec 6, 2022

@Apurva007 are you still working on this issue?

@github-actions github-actions bot removed the Stale label Dec 7, 2022
@Apurva007
Copy link
Contributor Author

@Apurva007 are you still working on this issue?

Hey @tisonkun . Yes will work on it this weekend.

@github-actions
Copy link

github-actions bot commented Jan 7, 2023

The issue had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Jan 7, 2023
@jak78
Copy link
Contributor

jak78 commented Mar 3, 2023

Hello @Apurva007 ! Are you still working on this issue?

@Apurva007
Copy link
Contributor Author

@jak78 Yes. I finished the tests this week. Will work on the PR this weekend. Apologies for the delay.

@github-actions github-actions bot removed the Stale label Mar 4, 2023
@Apurva007 Apurva007 mentioned this issue Mar 16, 2023
Merged
1 task
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

The issue had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Apr 4, 2023
@jak78
Copy link
Contributor

jak78 commented Apr 4, 2023

Hello @Apurva007 ! Are you still working on this issue?

@tisonkun
Copy link
Member

tisonkun commented Apr 4, 2023

@jak78 I found there is an ongoing patch apache/pulsar-site#473 but it seems the author doesn't move forward for some weeks.

@Apurva007
Copy link
Contributor Author

@tisonkun / @jak78 Yes, I am still working on this issue.

This was referenced Apr 4, 2023
Closed
Closed
@github-actions github-actions bot removed the Stale label Apr 5, 2023
@Apurva007 Apurva007 mentioned this issue Apr 6, 2023
Merged
15 tasks
@Apurva007
Copy link
Contributor Author

Created the PRs. Waiting for the CIs to pass. Currently the CI checks are failing due to #19952

@Apurva007
Copy link
Contributor Author

Fixed the CI checks using the codecov suggestion by adding a token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Apurva007 Apurva007

Labels
doc-required Your PR changes impact docs and you will update later. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@jak78 @Apurva007 @tisonkun @momo-jun