Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Expo android config plugins for onNewIntent #559

Closed
wants to merge 1 commit into from

Conversation

iway1
Copy link

@iway1 iway1 commented Jun 6, 2024

Adds android config plugin to fix expo support

Addresses #558

@iway1
Copy link
Author

iway1 commented Aug 17, 2024

I respectfully must ask - what's the point of having an expo plugin if it doesn't even work? why not just merge the PR so you actually have expo support? makes no sense

@akinzalowevidation
Copy link

akinzalowevidation commented Aug 19, 2024

I respectfully must ask - what's the point of having an expo plugin if it doesn't even work? why not just merge the PR so you actually have expo support? makes no sense

@amit-kremer93 I am also confused as to why this was closed with no comment. Is there another solution or was it fixed in another way?

@farhadatifc
Copy link

Thank you for that fix it works like a charm !

@chenyangyuAC
Copy link

@iway1 Thank you for the investigation and the work, I was also facing the same issue ( no setIntent() and cause onDeepLink() not triggered) and your changes fixed the issue.
Don't understand why they wouldn't even care to check the PR and just close this without comment.

@edwinvrgs
Copy link

edwinvrgs commented Sep 12, 2024

This should be opened again. I'm facing the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants