Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Expo support on Android #558

Open
iway1 opened this issue Jun 6, 2024 · 5 comments
Open

Fix Expo support on Android #558

iway1 opened this issue Jun 6, 2024 · 5 comments
Labels

Comments

@iway1
Copy link

iway1 commented Jun 6, 2024

Report

Plugin Version

6.14.3

On what Platform are you having the issue?

Android

Description

Hello,

Expo support in this library is currently broken / incomplete on Android. Specifically, after following the installations steps, onDeepLink handler will not be fired in case the app is backgrounded / running when the deep link is pressed.

This is because for this to work the MainActivity code has to override onNewIntent as specified here: https://dev.appsflyer.com/hc/docs/rn_deeplinkintegrate

However, this is not viable in Expo managed workflow because it involves manually editing native code. A config plugins should be added to modify this code during generation.

So, the expo setup guide is incomplete as it will not work on Android, and a config plugin is missing. Without this config plugin, this library does not support Expo since this critical functionality is missing.

Copy link

github-actions bot commented Jun 6, 2024

👋 Hi @iway1 and Thank you for reaching out to us.
In order for us to provide optimal support, please submit a ticket to our support team at [email protected].
When submitting the ticket, please specify:

  • ✅ your AppsFlyer sign-up (account) email
  • ✅ app ID
  • ✅ production steps
  • ✅ logs
  • ✅ code snippets
  • ✅ and any additional relevant information.

@iway1
Copy link
Author

iway1 commented Jun 7, 2024

@pazlavi I already talked to support about this, it was not helpful. This is not a "support" ticket, this is an issue with this library that needs to be fixed with code changes.

Additionally, I already fixed the issue in my own project with the linked pull request, so I don't need support because my project is working perfectly. I am opening this issue so that AppsFlyer team is aware that Expo support on Android is broken.

You should remove the support label from this issue and fix this issue, this is not a good look for AppsFlyer. Consider merging my pull request that fixes the issue.

@akinzalowevidation
Copy link

I am also experiencing this issue.

@chenyangyuAC
Copy link

chenyangyuAC commented Aug 20, 2024

Same issue. Suggest to reopen and merge the PR from @iway1 , or have anther release branches.

@edwinvrgs
Copy link

I'm also experiencing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants