Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test exec #27

Closed
wants to merge 19 commits into from
Closed

Test exec #27

wants to merge 19 commits into from

Conversation

dkroenke
Copy link

@dkroenke dkroenke commented Jul 28, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

  • Closes TBD

This change is Reviewable

elfenpiff and others added 19 commits July 21, 2022 16:35
…ove test files to follow file naming guideline

Signed-off-by: Christian Eltzschig <[email protected]>
Rework nightly job to be not used on master push,
but can now be triggered manually

Signed-off-by: Dietrich Krönke <[email protected]>
…e-full-clang-tidy-nightly-scan

iox-eclipse-iceoryx#1196 activate full clang-tidy nightly scan
…ng-tidy-warnings-in-pointer-repo

iox-eclipse-iceoryx#1196 Suppress clang-tidy and AUTOSAR warnings in `PointerRepository`
…e-clang-tidy-check-on-posix-wrappers

iox-eclipse-iceoryx#1196 activate clang-tidy check on posix wrapper
@codecov-commenter
Copy link

Codecov Report

Merging #27 (08fc945) into master (c30d930) will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   78.86%   78.90%   +0.03%     
==========================================
  Files         378      379       +1     
  Lines       14483    14489       +6     
  Branches     2028     2028              
==========================================
+ Hits        11422    11432      +10     
+ Misses       2433     2431       -2     
+ Partials      628      626       -2     
Flag Coverage Δ
unittests 78.56% <85.71%> (+0.03%) ⬆️
unittests_timing 14.89% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fs/internal/posix_wrapper/shared_memory_object.hpp 87.50% <ø> (ø)
...nternal/relocatable_pointer/pointer_repository.inl 88.63% <ø> (ø)
...eoryx_hoofs/source/posix_wrapper/message_queue.cpp 0.00% <ø> (ø)
...oofs/source/posix_wrapper/shared_memory_object.cpp 77.63% <50.00%> (-0.58%) ⬇️
...include/iceoryx_hoofs/internal/concurrent/sofi.inl 85.00% <90.90%> (+0.78%) ⬆️
...include/iceoryx_hoofs/internal/concurrent/sofi.hpp 100.00% <100.00%> (ø)
iceoryx_hoofs/source/posix_wrapper/named_pipe.cpp 59.37% <100.00%> (+0.86%) ⬆️
iceoryx_posh/source/mepoo/memory_manager.cpp 97.05% <0.00%> (+1.96%) ⬆️
iceoryx_hoofs/source/concurrent/loffli.cpp 91.42% <0.00%> (+5.71%) ⬆️

@dkroenke dkroenke closed this Jul 29, 2022
@dkroenke dkroenke deleted the test_exec branch December 8, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants