iox-#1196 activate clang-tidy check on posix wrapper

[elfenpiff]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
  • Each unit test case has a unique UUID
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Relates to Enable clang-tidy checks and fix warnings in code #1196

[codecov]

Codecov Report

Merging #1538 (28200ba) into master (c30d930) will increase coverage by 0.00%.
The diff coverage is 77.77%.

@@           Coverage Diff           @@
##           master    #1538   +/-   ##
=======================================
  Coverage   78.88%   78.88%           
=======================================
  Files         378      379    +1     
  Lines       14483    14489    +6     
  Branches     2028     2028           
=======================================
+ Hits        11425    11430    +5     
- Misses       2431     2432    +1     
  Partials      627      627           

Flag	Coverage Δ
unittests	78.54% <77.77%> (+<0.01%)	⬆️
unittests_timing	14.90% <0.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...fs/internal/posix_wrapper/shared_memory_object.hpp	87.50% <ø> (ø)
...eoryx_hoofs/source/posix_wrapper/message_queue.cpp	0.00% <ø> (ø)
...oofs/source/posix_wrapper/shared_memory_object.cpp	77.63% <50.00%> (-0.58%)	⬇️
iceoryx_hoofs/source/posix_wrapper/named_pipe.cpp	59.37% <100.00%> (+0.86%)	⬆️
iceoryx_hoofs/source/concurrent/loffli.cpp	85.71% <0.00%> (-2.86%)	⬇️
...nternal/relocatable_pointer/pointer_repository.inl	88.63% <0.00%> (ø)
...include/iceoryx_hoofs/internal/concurrent/sofi.hpp	100.00% <0.00%> (ø)
...include/iceoryx_hoofs/internal/concurrent/sofi.inl	85.00% <0.00%> (+0.78%)	⬆️

[dkroenke]

Shouldn't we at least drop a warning or information to the user that we remove the leading slash here?

[elfenpiff]

No not at all. In the end the ipc channel contract is to provide a valid file name (which does not allow slashes) in the IPC channel.
This still needs to be refactored somehow, since some IPC channels require slashes (message queue), some allow full paths (named pipe) and some only require a valid file name (unix domain socket).

This all has to be handled by an abstraction above those constructs which will be introduced in: #1451

Until then I would leave it as it is and then refactor it step by step especially since the NamedPipe is only used in Windows.

[mossmaurice]

LGTM, left one question.