Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better URL sanitization in ape-geth connection [APE-1233] #1568

Merged
merged 3 commits into from
Jul 27, 2023
Merged

fix: better URL sanitization in ape-geth connection [APE-1233] #1568

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df9e37e
fix: rm e
antazoey Jul 27, 2023
f82dcec
fix: better url sanitize
antazoey Jul 27, 2023
64b2bef
Merge branch 'main' into fix/better-url-sanitize
antazoey Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ape_geth/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,10 @@ def geth_config(self) -> GethConfig:

@property
def _clean_uri(self) -> str:
return str(URL(self.uri).with_user(None).with_password(None))
url = URL(self.uri).with_user(None).with_password(None)
# If there is a path, hide it but show that you are hiding it.
# Use string interpolation to prevent URL-character encoding.
return f"{url.with_path('')}/[hidden]" if url.path else f"{url}"

@property
def ipc_path(self) -> Path:
Expand Down
Loading