fix: better URL sanitization in ape-geth connection [APE-1233]
#1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
ape-geth connectionape-geth connection [APE-1233]
antazoey
force-pushed
the
fix/better-url-sanitize
branch
from
2f3fe70
to
f82dcec
Compare
fubuloubu
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Noticed that if your URL contains API keys, they would not get sanitized properly.
I think the only way we can really do this in such a generic way to just always sanitize the path when they exist.
How I did it
Check if there is a path.
If there is, do
with_path("")and put[hidden]at the end of the URL.(I borrowed this from some AWS logs I happened to see).
Otherwise, keep as normal, so
[hidden]is only appended when actually hiding the path.How to verify it
This was my log before (except im not actually pasting my API key, but it was where
apikeythatwasnotactuallyhiddenis):This is in it now, so the whole path is just
[hidden]now.Checklist