feat: improved contract receipt related logic #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
antazoey
changed the title
fubuloubu
reviewed
Jul 18, 2023
antazoey
force-pushed
the
perf/event-start-block
branch
from
9218500
to
6f12790
Compare
antazoey
force-pushed
the
perf/event-start-block
branch
from
0d56d8f
to
28bf02e
Compare
fubuloubu
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Please review + merge #1547 first! this PR depends on those changes so it has all the same changes but i will rebase after and the diff will look nicer. I am leaving it in draft until that is done
chain.get_contract_receipt()method to help get receipts for contracts.receiptonContractInstanceto no longer be optional. If it does not have it, it will call the new method to get it.start_blockto use the start block of the contract's receipt when not given for event queriesHow I did it
@fubuloubu wrote the start of the algo, i fixed the bug in it, pasted in it, made mypy happy, added some tests, wired it up in some places that make it work nicely in the bg.
How to verify it
Checklist