refactor: daemon updates [SBK-173] #17
Conversation
SBK-173 "refactor: daemon updates" (ApeWorX/ApePay #17)
ApeWorX/ApePay #17 by fubuloubu on GitHub via LinearSync |
fubuloubu
force-pushed
the
refactor/script-updates
branch
3 times, most recently
from
8782d82
to
1b8dd84
Compare
apepay/__init__.py
Outdated
| # return self.chain_manager.contracts.instance_at(self.address) | ||
| try: | ||
| return self.chain_manager.contracts.instance_at(self.address) | ||
| except Exception: |
There was a problem hiding this comment.
what types of exceptions do you expect here? wondering if we could mitigate anything upstream?
There was a problem hiding this comment.
Could reduce to the "contract not found" error, only need to fallback on a local network or if we don't have an explorer (although it still won't work unless we somehow bundle the manifest)
There was a problem hiding this comment.
this will make it a little nicer: https://github.com/ApeWorX/ape/pull/1551/files
apepay/__init__.py
Outdated
| return self.project_manager.StreamManager.at(self.address) | ||
| # return self.chain_manager.contracts.instance_at(self.address) | ||
| try: | ||
| return self.chain_manager.contracts.instance_at(self.address) |
There was a problem hiding this comment.
eventually we will want to include the contracts and reference the project via manifest, right?
antazoey
force-pushed
the
refactor/script-updates
branch
from
ac1f84d
to
806c17f
Compare
| @@ -51,16 +52,21 @@ def validate(self, creator, token, amount_per_second, reason) -> bool: | |||
|
|
|||
| class StreamManager(BaseInterfaceModel): | |||
| address: AddressType | |||
| contract_type: Optional[ContractType] = None | |||
There was a problem hiding this comment.
I want to somehow bundle the manifest/contract type with the package so that we always have this as a backup
antazoey
force-pushed
the
refactor/script-updates
branch
from
806c17f
to
8b012bf
Compare
Got it working on Sepolia