Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct batch memory limit #7

Closed
wants to merge 28 commits into from
Closed

Correct batch memory limit #7

wants to merge 28 commits into from

Conversation

AnonHxy
Copy link
Owner

@AnonHxy AnonHxy commented Oct 5, 2022

Upstream PR apache#17936

Pomelongan and others added 26 commits October 10, 2022 17:33
* [fxi][doc] Rewrite the steps of docker-deploy
### Motivation
The old implementation is incompletely.
### Modification
Rewrite it.
…ered when using batch receive and trigger timeout. (apache#17318)
* [fix][doc] SVG files and references

Signed-off-by: tison <[email protected]>
Co-authored-by: Dave Duggins <[email protected]>

* fix one more broken syntax on the fly

Signed-off-by: tison <[email protected]>

Signed-off-by: tison <[email protected]>
Co-authored-by: Dave Duggins <[email protected]>
…18002)

* [fix][CI] Use GitHub Actions actions/checkout@v3

- Node.js 12 actions are deprecated.
  For more information see:
  https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

* Also upgrade actions/cache and actions/setup-java
…Codecov (apache#17382)

* [improve][ci] Generate jacoco code coverage reports and upload to CodeCov

* [improve][ci] Generate jacoco code coverage reports and upload to CodeCov

* [improve][ci] Generate jacoco code coverage reports and upload to CodeCov

* [improve][ci] Generate jacoco code coverage reports and upload to CodeCov

* Add codecov configuration file

* Update codecov.yml

Co-authored-by: tison <[email protected]>

* Change codecov comment behaviour configuration to default to reduce the email notification times.

* Allow CodeCov upload report job can be failure

* Include only apache/pulsar class to generate jacoco tests

* Include only apache/pulsar class to generate jacoco tests

* Exclude class files in META-INF and skip pulsar-all-docker-image in test_group_other

* Remove generate jacoco reports step in pulsar-ci

Co-authored-by: tison <[email protected]>
* [fix][bookie] Correctly handle list configuration values

* Remove unused import

### Motivation

When the `metadataServiceUri` or the `zkServers` configuration for `BookieRackAffinityMapping` is provided as a comma delimited list, it is automatically parsed into an ArrayList by the configuration class because the Bookkeeper configuration class relies on the defaults in the `org.apache.commons.configuration.AbstractConfiguration` class. Here is a sample error:

```
2022-07-29T19:25:43,437+0000 [main] ERROR org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Failed to initialize DNS Resolver org.apache.pulsar.zookeeper.ZkBookieRackAffinityMapping, used default subnet resolver
java.lang.ClassCastException: class java.util.ArrayList cannot be cast to class java.lang.String (java.util.ArrayList and java.lang.String are in module java.base of loader 'bootstrap')
```

Also, see apache#6349 and apache#6343 for context.

### Modifications

* Move the `castToString` method out to a shared class.
* Use the `castToString` method to safely get the configuration value.

### Verifying this change

This PR includes a test.

### Documentation

- [x] `doc-not-needed`
…#16225)

### Motivation

In apache#13950, we switched an error log to an info log. @hsaputra requested on Pulsar Slack we use warn level so that alerts still fire in for the case when the topic is not found.

### Modifications

* Replace `info` with `warn` when topic is not found in the `ServerCnx` class.
- [x] `doc-not-needed`
@AnonHxy AnonHxy closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.