Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][broker]remove methods no longer used in AdminResource #7 #17969

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

Pomelongan
Copy link
Contributor

Motivation

org.apache.pulsar.broker.admin.AdminResource#fetchPartitionedTopicMetadataCheckAllowAutoCreation and org.apache.pulsar.broker.admin.AdminResource#fetchPartitionedTopicMetadata are no longer used.

Modifications

remove org.apache.pulsar.broker.admin.AdminResource#fetchPartitionedTopicMetadataCheckAllowAutoCreation and org.apache.pulsar.broker.admin.AdminResource#fetchPartitionedTopicMetadata.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: Pomelongan#7

…d fetchPartitionedTopicMetadata that are no longer used in AdminResource
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 8, 2022
@HQebupt
Copy link
Contributor

HQebupt commented Oct 8, 2022

Please check the unused import, such as import org.apache.pulsar.broker.PulsarService;

@Pomelongan
Copy link
Contributor Author

Please check the unused import, such as import org.apache.pulsar.broker.PulsarService;
I have updated it.PTAL @HQebupt

@codelipenghui codelipenghui merged commit ca648b2 into apache:master Oct 10, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Oct 10, 2022
@codelipenghui codelipenghui added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/broker labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants