forked from nightscout/cgm-remote-monitor
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update before moving data to mLab #2
Open
AndreChampy
wants to merge
720
commits into
AndreChampy:master
Choose a base branch
from
nightscout:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps create an area for developing towards the next version.
Allow users to choose whether or not to reveal the provenance of the data to consumers. This is intended to help protect data rights to portability and access. If consumers start abusing or discriminating against Nightscout users due to the source of the data, this allows users to conceal this information.
Disregard brand of device when considering glucose values. By de facto usage, the meaning of LOW and HIGH within Nightscout means that glucose is beyond limits. LOW means 40 or lower. HIGH means 400 or higher. Both tend to invite questioning therapy options, including inspecting if the device is working correctly, as well as potential treatment options.
The results to render may come from an in-memory cache, or from the database. If they came from the in-memory cache, it's possible that obscurring the device field could actually change the values in memory. When obscurring, the device field, this patch copies all of the values in order to ensure that the in-memory copies are unaffected. With this patch, cached objects should not be affected.
With this change, any code referencing the sandbox or /api/v2/properties for plugin will also benefit from having the device information obscured.
…/cgm-remote-monitor into wip/bewest/obscure-provenance
obscure private device provenance
…rdless of units (#7273)
Temporarily use git references to share2nightscout-bridge and minimed-connect-to-nightscout in order to help test similar changes in those packages.
The tests pass cleanly.
Change deduping interval
Run tests also against nodejs 16.x
Omnipod reservoir fixes
Fix expiration time on remote notifications for Loop
Support automatic bolus volumes in the enacted field for loop status.
Given node 18 and 20, allow running on any LTS version of node. We can block out bad versions if needed.
Use npm install under node 14 generates different lock file.
This patch adjusts the user feedback while the server is initializing to communicate that Nightscout startup sequence should take closer to 15 second than 5 seconds.
Record output of npm instlal using oldest supported version.
Record changes from upgrading nightscout-connect to at least the latest release, 0.0.12.
Mongo driver update & less frequent database polls
New Crowdin updates
dev - candidate for release 15.0.0
Revert "Merge pull request #8026 from nightscout/less_frequent_db_upd…
Releasing 15.0.1, hotfix to revert series of changes affecting mongodb that were not quite ready.
The allowEIO3, when set to true allows v2 clients to connect while the default is false. This patch should allow versions of AndroidAPS older than 3.2 to connect to NS15 and above. Thanks to Dave Carlson for researching and experimenting with this option! https://socket.io/docs/v4/migrating-from-2-x-to-3-0/#how-to-upgrade-an-existing-production-deployment https://socket.io/docs/v4/server-options/#alloweio3
socket.io: enable legacy v2 connections
This patch is intended to allow customizing the behavior for whether or not to prompt for authorization before subscribing or acknolweding alarms. There was a bug in previous attempts where the profileeditor would be double initialized, causing the profileeditor to remove some buttons from the GUI. This patch adds checking for a permission specifically related to acknolwedging alarms, as well as avoids double-initializing the editor, which causes the issue with the GUI.
This patch eliminates debugging logging in favor of commentary to capture how, where, and why alarmSocket feature is causing different pages to demand the authentication prompt in a variety of circumstances.
Create an opportunity to respond with something other than a global ack when someone that is not authorized sends an acknolwedgement to an alarm. Eliminate double-initializing when subscribing to alarms. The `callback` variable is not local to the function, anyway.
When someone is looking at Nightscout and needs the alarm silenced, it is very desirable to always silence the local UI. This patch documents some of the working code around handling the alarm notification process, as well as provides commentary on handling unauthorized scenarios. There are some open questions such as how to update the permission set after authorization.
alarmSocket: customizing authorization requirements
Dev branch for next release, 15.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.