obscure private device provenance #7249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to choose whether or not to reveal the provenance of the data to consumers. This is intended to help protect data rights to portability and access. If consumers start abusing or discriminating against Nightscout users due to the source of the data, this allows users to conceal this information.
sulkaharo
reviewed
Dec 15, 2021
Disregard brand of device when considering glucose values. By de facto usage, the meaning of LOW and HIGH within Nightscout means that glucose is beyond limits. LOW means 40 or lower. HIGH means 400 or higher. Both tend to invite questioning therapy options, including inspecting if the device is working correctly, as well as potential treatment options.
The results to render may come from an in-memory cache, or from the database. If they came from the in-memory cache, it's possible that obscurring the device field could actually change the values in memory. When obscurring, the device field, this patch copies all of the values in order to ensure that the in-memory copies are unaffected. With this patch, cached objects should not be affected.
With this change, any code referencing the sandbox or /api/v2/properties for plugin will also benefit from having the device information obscured.
…/cgm-remote-monitor into wip/bewest/obscure-provenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to choose whether or not to reveal the provenance of the data to
consumers. This is intended to help protect data rights to portability and
access. If consumers start abusing or discriminating against Nightscout users
due to the source of the data, this allows users to conceal this information.