Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use legacy environment enabled build for draco decoder module #6404

Closed
ggetz opened this issue Apr 2, 2018 · 8 comments
Closed

Use legacy environment enabled build for draco decoder module #6404

ggetz opened this issue Apr 2, 2018 · 8 comments

Comments

@ggetz
Copy link
Contributor

ggetz commented Apr 2, 2018

CC #6399

There's an error when loading the draco decoder module in IE as the build of the deocder we are using (https://github.com/google/draco#javascript-encoderdecoder) does not support IE as it is a "Legacy environment". We need to use a version built with legacy support.

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 3, 2018

Isn't this duplicate with #6399?

Did we ship 1.44 with Draco not working IE? Does it at least fail gracefully?

@ggetz
Copy link
Contributor Author

ggetz commented Apr 3, 2018

Closed #6399 to allow it it fail gracefully, and opened this as we need to rebuild the draco module itself.

@mramato
Copy link
Contributor

mramato commented Apr 26, 2018

@ggetz is this fixed with #6420? If not, is it still planned for May 1?

@ggetz
Copy link
Contributor Author

ggetz commented Apr 26, 2018

This was not fixed in #6420, I will try to take a look this afternoon or tomorrow to see if we can get this in for May 1.

@mramato
Copy link
Contributor

mramato commented May 8, 2018

@ggetz are you actively working this? It's currently holding up several other Cesium PRs.

@ggetz
Copy link
Contributor Author

ggetz commented May 8, 2018

@mramato Sorry, I know it's holding up PRs, but I'm not sure I'll be able to get to it this week with other deadlines.

@mramato
Copy link
Contributor

mramato commented May 8, 2018

@pjcozzi any thoughts here? Lack of Draco in IE11 is holding up both Draco point cloud support and updating all of the default ion tilesets to Draco. I was really hoping to have Draco assets in Cesium for FOSS4G since they are so much smaller/faster.

One option is to just not worry about IE11 in master but make sure we fix in for June 1.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 8, 2018

Sorry we need to finish the 3D Tiles spec tweaks first - will only be a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants