Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilt draco module with support for IE11 #6626

Merged
merged 1 commit into from
May 25, 2018
Merged

Rebuilt draco module with support for IE11 #6626

merged 1 commit into from
May 25, 2018

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented May 24, 2018

Fixes #6404

Rebuild the draco decoder JS module and passed the compile flag -s LEGACY_VM_SUPPORT=1 to Emscripten (which includes some polyfills, see emscripten-core/emscripten#6204). I saw no difference in decode time when compared with the "official" draco JS decoder module (and IE11 doesn't support wasm at all). The new module is only 1KB bigger size, so I just replaced the previous version with this legacy-enabled module rather than having a fallback

@ggetz ggetz requested a review from lilleyse May 24, 2018 18:39
@cesium-concierge
Copy link

Signed CLA is on file.

@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.

⚠️ I noticed that a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version. Once you do, please confirm by commenting on this pull request.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented May 24, 2018

I can confirm this works! But I'll let @lilleyse take a quick peak and merge

@mramato
Copy link
Contributor

mramato commented May 24, 2018

Can we please document somewhere (dev guide?) exactly how to update draco dependencies for Cesium since we can no longer rely on the official non-wasm releases.

@ggetz
Copy link
Contributor Author

ggetz commented May 24, 2018

@mramato I have a modified draco CMakeLists.txt file. Should I put a branch of my fork of Draco and link to it?

@lilleyse
Copy link
Contributor

I can also confirm Draco works in IE and tests pass.

As we predicted, the decode is pretty slow in IE. It shouldn't hold back this PR but it might be worth considering for #6555.

Draco vs. uncompressed:
nyc-draco
nyc

@ggetz
Copy link
Contributor Author

ggetz commented May 25, 2018

@lilleyse The reason for that is that IE doesn't support WebAssembly at all, therefor we always have to fallback on the JS module which is significantly slower, rebuilt or not.

@lilleyse
Copy link
Contributor

Yeah, plus the number of web workers is limited in IE. I'm not too surprised by the results but thought it was worth documenting.

@lilleyse
Copy link
Contributor

Thanks @ggetz!

@lilleyse lilleyse merged commit eeabac3 into master May 25, 2018
@lilleyse lilleyse deleted the draco-ie branch May 25, 2018 15:15
@OmarShehata
Copy link
Contributor

Can we please document somewhere (dev guide?) exactly how to update draco dependencies for Cesium since we can no longer rely on the official non-wasm releases.

Was this ever documented @ggetz ? I don't see anything about it here:

https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Documentation/Contributors/BuildGuide/README.md

I'm asking because the WebP decoder WASM will have the same workflow (WASM, with an ASM fallback?) and I curious if the Draco steps were written anywhere as reference when documenting mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants