Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clearer error message #6405

Merged
merged 4 commits into from
Apr 2, 2018
Merged

Add clearer error message #6405

merged 4 commits into from
Apr 2, 2018

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Apr 2, 2018

Fixes ##6399 with a clearer error.

Opened #6404 for a better fix by using the legacy enabled build of the draco decoder module.

@ggetz ggetz requested a review from lilleyse April 2, 2018 19:24
@cesium-concierge
Copy link

Signed CLA is on file.

@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

hpinkos
hpinkos reviewed Apr 2, 2018
View reviewed changes
Source/Scene/DracoLoader.js Outdated
@@ -177,6 +177,12 @@ define([
return when.resolve();
}

if (FeatureDetection.isInternetExplorer()) {
return when.reject({
message : 'Draco decoding is not supported in legacy environments.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be a little more obvious, maybe just say "Draco decoding is not currently support in Internet Explorer"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I was just using the terminology the module itself reports.

@hpinkos
Copy link
Contributor

hpinkos commented Apr 2, 2018

@ggetz Add a comment about this in CHANGES.md too. And link to the issue about adding support in the future.

@ggetz
Copy link
Contributor Author

ggetz commented Apr 2, 2018

Thanks @hpinkos, updated!

@hpinkos
Copy link
Contributor

hpinkos commented Apr 2, 2018

One more thing (sorry for not thinking of this before)
Add an isSupported attribute, similarly to GroundPrimitive.isSupported

@hpinkos
Copy link
Contributor

hpinkos commented Apr 2, 2018

And probably also mention the isSupported attribute in CHANGES.md

@ggetz
Copy link
Contributor Author

ggetz commented Apr 2, 2018

DracoLoader isn't part of the public API, should it still have the isSupported attribute? Should I add a isDracoDecodingSupported attribute to Model?

@hpinkos
Copy link
Contributor

hpinkos commented Apr 2, 2018

Oooh, gotcha. Yeah, nevermind then, I think this is fine =)

@hpinkos
Copy link
Contributor

hpinkos commented Apr 2, 2018

Thanks @ggetz!

@hpinkos hpinkos merged commit df71a53 into master Apr 2, 2018
@hpinkos hpinkos deleted the draco-check-ie branch April 2, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpinkos hpinkos hpinkos left review comments

@lilleyse lilleyse Awaiting requested review from lilleyse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggetz @cesium-concierge @hpinkos