Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite assets path for storybook github pages builds #95

Merged

Conversation

thescientist13
Copy link
Contributor

Related Issue

resolves #94

Summary of Changes

  1. Set a "public path" / base href for GitHub pages deployments to account for sub path hosting

Can confirm it works for local testing at least 🤞
Screen Shot 2022-12-03 at 2 52 52 PM

@thescientist13 thescientist13 force-pushed the chore/issue-94-storybook-github-pages-public-path-fix branch from 49f32bf to a1c8d50 Compare December 3, 2022 20:47
@thescientist13 thescientist13 merged commit c2a5cf2 into main Dec 3, 2022
@thescientist13 thescientist13 deleted the chore/issue-94-storybook-github-pages-public-path-fix branch December 3, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook images not showing in GitHub Pages
1 participant