Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook images not showing in GitHub Pages #94

Closed
thescientist13 opened this issue Nov 21, 2022 · 4 comments · Fixed by #95
Closed

Storybook images not showing in GitHub Pages #94

thescientist13 opened this issue Nov 21, 2022 · 4 comments · Fixed by #95
Assignees
@thescientist13
Labels
documentation Improvements or additions to documentation

Comments

@thescientist13
Copy link
Contributor

After publishing to GitHub Pages in #93 , it looks like the static assets (images) aren't showing up.
https://analogstudiosri.github.io/www.tuesdaystunes.tv/?path=/story/components-footer--primary
Screen Shot 2022-11-21 at 5 57 27 PM

Not sure what it is? 🤔
@thescientist13 thescientist13 added the documentation Improvements or additions to documentation label Nov 21, 2022
@thescientist13
Copy link
Contributor Author

Found these threads, not sure if there is something useful here?

@thescientist13 thescientist13 moved this from 🔖 Ready to 🏗 In progress in TT.tv Website Design (v1) Nov 21, 2022
@thescientist13
Copy link
Contributor Author

Ah, with the network tab open, it seems all the paths are relative to analogstudiosri.github.io
Screen Shot 2022-11-21 at 6 06 26 PM

So for GitHub Pages, we somehow need to set the publicPath to account for the www.tuesdaystunes.tv or make all the paths relative?

@thescientist13
Copy link
Contributor Author

thescientist13 commented Dec 3, 2022 •
edited
Loading

Found a thread on this here with some various solutions for customizing publicPath, with this option looking to be the most promising.

@thescientist13 thescientist13 mentioned this issue Dec 3, 2022
Merged
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in TT.tv Website Design (v1) Dec 3, 2022
@thescientist13
Copy link
Contributor Author

Ah, had to explicitly set it through the configuration file
62c6e81

jobs:

  build-and-deploy:
    runs-on: ubuntu-18.04
    env:
      GH_PAGES: true

Screen Shot 2022-12-03 at 3 58 15 PM

@thescientist13 thescientist13 moved this from 👀 In review to ✅ Done in TT.tv Website Design (v1) Dec 3, 2022
@thescientist13 thescientist13 self-assigned this Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
documentation Improvements or additions to documentation
Projects
TT.tv Website Design (v1)
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rewrite assets path for storybook github pages builds AnalogStudiosRI/www.tuesdaystunes.tv
1 participant
@thescientist13