update to 1.62.2 #31
update to 1.62.2 #31
Conversation
automerged PR by conda-forge/automerge-action
…nda-forge-pinning 2022.08.12.23.25.47
…-c-ares1-0-1_h685e74 Rebuild for c-ares1
…nda-forge-pinning 2022.08.15.17.58.52
automerged PR by conda-forge/automerge-action
take status of patches for 1.47.x from conda-forge#225
Private linkage for zlib & abseil
…nda-forge-pinning 2022.08.27.13.34.34
automerged PR by conda-forge/automerge-action
automerged PR by conda-forge/automerge-action
Co-Authored-By: H. Vetinari <[email protected]>
…nda-forge-pinning 2024.03.06.02.49.17
automerged PR by conda-forge/automerge-action
…nda-forge-pinning 2024.03.08.18.51.49
…h6642bf grpc-cpp v1.62.1
…nda-forge-pinning 2024.04.17.16.16.29
| - wheel >=0.29 | ||
| - abseil-cpp 20230802.0 | ||
| - c-ares 1.19.1 | ||
| - libprotobuf {{ libprotobuf }} |
There was a problem hiding this comment.
Is protobuf required for building grpcio? Or it's only for examples and/or testing?
See https://github.com/grpc/grpc/blob/v1.62.2/requirements.txt#L4
| - pkg-config | ||
| files: | ||
| - tests/include/* | ||
| - cmake_test/ |
There was a problem hiding this comment.
I'm failing to see the difference between files and source_files? Shouldn't hello.proto be part of source_files?
There was a problem hiding this comment.
files takes files from the recipe directory: https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#test-files
| - ninja | ||
| - cmake | ||
| - ninja-base | ||
| # During cross-compilation, we need to build the grpc_cpp_plugin for the |
There was a problem hiding this comment.
maybe I'm missing something, but when do we do cross compilation?
There was a problem hiding this comment.
We don't, but most changes here are synced from conda-forge.
| - ninja | ||
| - cmake | ||
| - ninja-base | ||
| # During cross-compilation, we need to build the grpc_cpp_plugin for the |
There was a problem hiding this comment.
maybe I'm missing something, but when do we do cross compilation?
There was a problem hiding this comment.
We don't, but most changes here are synced from conda-forge.
There was a problem hiding this comment.
Looks good to me. I went though the build logs for linux-64, osx-arm64 and win-64, looked at the DSO analysis, looked at the cython compiler flags and I also took a quick look at the installed files. I also inspected the builds scripts and nothing in particular catched my attention.
I did notice https://github.com/grpc/grpc/blob/v1.62.2/setup.py#L299-L322 on the setup.py though. But I think it should be mostly fine. Same for https://github.com/grpc/grpc/blob/v1.62.2/setup.py#L53-L81.
I don't think we necessarily need to fix this right now. It could well be done in another PR (since this PR is already big enough). I think it's something we could also contribute back in the conda-forge feedstock.
Include directories are processed in left to right order, so this works as expected. |
grpcio 1.62.2
Destination channel: main
Links
Explanation of changes: