-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKG-4723 20240116.2 #9
Conversation
…da-forge-pinning 2021.03.29.15.45.30
….0_hd37b9e abseil-cpp v20210324.0
…nda-forge-pinning 2021.04.20.18.36.07
….1_h8c8c1b abseil-cpp v20210324.1
…nda-forge-pinning 2021.06.01.05.21.06
…nda-forge-pinning 2021.11.10.21.33.30
…nda-forge-pinning 2022.02.14.13.20.49
automerged PR by conda-forge/automerge-action
…nda-forge-pinning 2022.02.19.23.26.53
Windows shared builds
…nda-forge-pinning 2022.02.28.13.05.22
…join Join as maintainer
automerged PR by conda-forge/automerge-action
Uninline Mutex::Dtor also on linux
automerged PR by conda-forge/automerge-action
…nda-forge-pinning 2024.04.08.16.26.39
….2_he072f1 abseil-cpp v20240116.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started looking at this, will split over multiple days as it's v big.
If you're able to isolate the relevant discussions for the changes on conda-forge that would be helpful; the links include discussions around historical updates, protobuf, etc. (or do I need to read the whole thing for context..?)
- cmake | ||
- ninja-base | ||
host: | ||
- gtest 1.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see where gtest is being used, or the test binaries are being used (beyond checking that they're present)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for abseil_test_dll, included in this pacakge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do the test binaries get run? or does it ship a test suite for use by devs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libprotobuf does make use of abseil test binaries to built its own test binaries
Tp put it short, all packages depending on abseil must be built with cxx 17 at least. Also, even minor updates can induce breaking changes. The other relevant change is conda-forge renaming the package from abseil-cpp to libabseil. |
abseil-cpp 20240116.2
Destination channel: main
Links
Explanation of changes: