Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Update alert appearance, make ‘warning’ the default and icon non-optional #993

Merged
merged 18 commits into from
Jan 10, 2024

Conversation

VincentSmedinga
Copy link
Contributor

  • Updates to latest design: background now white, corrected text levels
  • Adds a border token; not sure if the current set is exactly correct
  • Uses Heading component to display title
  • Adds ‘warning’ severity and makes it default
  • Removes icon prop – distinguishing colour alone is not enough
  • Hmm, this could / should have been 3 separate PRs
  • Extends and organizes documentation, although not complete yet

@github-actions github-actions bot temporarily deployed to demo-DES-543-update-alert-appearance December 22, 2023 12:48 Destroyed
@alimpens alimpens mentioned this pull request Jan 5, 2024
packages/css/src/components/alert/README.md Outdated Show resolved Hide resolved
packages/react/src/Alert/Alert.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Alert/Alert.test.tsx Show resolved Hide resolved
packages/react/src/Alert/Alert.tsx Outdated Show resolved Hide resolved
packages/react/src/Alert/Alert.tsx Outdated Show resolved Hide resolved
proprietary/tokens/src/common/amsterdam/border.tokens.json Outdated Show resolved Hide resolved
storybook/storybook-react/src/Alert/Alert.docs.mdx Outdated Show resolved Hide resolved
storybook/storybook-react/src/Alert/Alert.stories.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-543-update-alert-appearance January 9, 2024 13:04 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-543-update-alert-appearance January 10, 2024 07:09 Destroyed
@alimpens alimpens merged commit df15253 into develop Jan 10, 2024
4 checks passed
@alimpens alimpens deleted the feature/DES-543-update-alert-appearance branch January 10, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants