-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add icon button #1021
feat!: Add icon button #1021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup in the other components!
proprietary/tokens/src/components/amsterdam/icon-button.tokens.json
Outdated
Show resolved
Hide resolved
proprietary/tokens/src/components/amsterdam/icon-button.tokens.json
Outdated
Show resolved
Hide resolved
We should strongly advise against disabling buttons in general, but I don’t think we can leave them out. I expect some disabled icon buttons in applications, e.g. to add or remove something an item from a set.
Let‘s explore this separately. If we keep using it, we should make clear which backgrounds are light and which are dark. I’ve left some comments on this with the code as well. We use it in other places; no need to hold back this PR.
Yes, I’ll make a task to remember that. |
Co-authored-by: Vincent Smedinga <[email protected]>
Co-authored-by: Vincent Smedinga <[email protected]>
Co-authored-by: Vincent Smedinga <[email protected]>
Good point, I'll add it!
Agreed, I've made a ticket for this
|
Some questions:
The Alert component should use the Icon Button as well. I didn't do that in this PR to prevent conflict with this PR