Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix feature branch cleanup workflow #1730

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

alimpens
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It fixes an error in our feature branch cleanup workflow. The workflow tried to access an .nvmrc file that doesn't exist in the gh-pages branch.

Why

Because our workflow was broken.

How

It checks out the feature branch first, which does have the .nvmrc file. It uses it, and then checks out the gh-pages branch.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Copy link
Contributor

@RubenSibon RubenSibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really judge, but if it has been tested it's good to go!

@VincentSmedinga VincentSmedinga merged commit 76411eb into develop Oct 30, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the task/fix-feature-branch-cleanup branch October 30, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants