chore: Fix feature branch cleanup workflow (#1730)

Amsterdam · Oct 30, 2024 · 76411eb · 76411eb
1 parent c075327
commit 76411eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/.github/workflows/feature-branch-cleanup.yml b/.github/workflows/feature-branch-cleanup.yml
@@ -19,15 +19,18 @@ jobs:
           BRANCH_NAME=$(echo $RAW_BRANCH_NAME | sed 's/[^/]*\///')
           echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_ENV
 
-      - name: Check out
+      - name: Check out branch to access .nvmrc
         uses: actions/checkout@v4
-        with:
-          ref: gh-pages
 
       - uses: actions/setup-node@v4
         with:
           node-version-file: .nvmrc
 
+      - name: Check out gh-pages branch
+        uses: actions/checkout@v4
+        with:
+          ref: gh-pages
+
       - name: Delete folder
         run: |
           git config --global user.name GitHub Action

diff --git a/.github/workflows/feature-branch-deploy.yml b/.github/workflows/feature-branch-deploy.yml
@@ -54,11 +54,6 @@ jobs:
         run: |
           touch ./storybook/dist/${{ github.sha }}.txt
 
-      # Our workflows use .nvmrc instead of a fixed version, so we need to copy this file over
-      # to the dist files for use in the feature branch cleanup workflow
-      - name: Copy over .nvmrc to dist
-        run: cp .nvmrc ./storybook/dist/
-
       - name: Pushing to pages branch
         uses: JamesIves/github-pages-deploy-action@v4
         with: