Rewriting tansu with a signal-first approach #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 1 16 +15
Lines 637 856 +219
Branches 105 133 +28
==========================================
+ Hits 637 856 +219 ☔ View full report in Codecov by Sentry. |
divdavem
force-pushed
the
signalFirst
branch
5 times, most recently
from
6d4a4bc to
dbc8b77
Compare
divdavem
force-pushed
the
signalFirst
branch
3 times, most recently
from
6eac539 to
1b44df6
Compare
divdavem
force-pushed
the
signalFirst
branch
5 times, most recently
from
6826332 to
9832d0a
Compare
divdavem
force-pushed
the
signalFirst
branch
from
9832d0a to
68ef7d3
Compare
divdavem
added a commit
to divdavem/signal-polyfill
that referenced
this pull request
Nov 13, 2024
divdavem
added a commit
to divdavem/signal-polyfill
that referenced
this pull request
Nov 21, 2024
divdavem
force-pushed
the
signalFirst
branch
from
91e4089 to
a5afe4f
Compare
|
@quentinderoubaix Thank you very much for your review. I think I have taken into account all your comments. @fbasso @quentinderoubaix Is it ok for you to merge this PR as it is now and to release the corresponding new version of tansu (2.0) ? |
divdavem
force-pushed
the
signalFirst
branch
2 times, most recently
from
ef4c03d to
f5a6fd9
Compare
divdavem
force-pushed
the
signalFirst
branch
from
f5a6fd9 to
bc50b2b
Compare
fbasso
approved these changes
Dec 3, 2024
quentinderoubaix
approved these changes
Dec 4, 2024
|
@fbasso @quentinderoubaix Thank you for your tests and review! |
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.