Code review changes

AmadeusITGroup · Nov 12, 2024 · 68ef7d3 · 68ef7d3
1 parent 4c45668
commit 68ef7d3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/internal/storeComputed.ts b/src/internal/storeComputed.ts
@@ -56,8 +56,7 @@ export class RawStoreComputed<T>
     let link = producerLinks[producerIndex] as L | undefined;
     if (link?.producer !== producer) {
       if (link) {
-        const endIndex = Math.max(producerIndex + 1, producerLinks.length);
-        producerLinks[endIndex] = link; // push the existing link at the end (to be removed later)
+        producerLinks.push(link); // push the existing link at the end (to be removed later)
       }
       link = producer.registerConsumer(producer.newLink(this));
     }

diff --git a/src/internal/storeConst.ts b/src/internal/storeConst.ts
@@ -18,7 +18,7 @@ export class RawStoreConst<T> implements RawStore<T, BaseLink<T>> {
     return link;
   }
   unregisterConsumer(_link: BaseLink<T>): void {}
-  updateValue(_link?: BaseLink<T> | undefined): void {}
+  updateValue(): void {}
   isLinkUpToDate(_link: BaseLink<T>): boolean {
     return true;
   }