Bugfixes #595 and #587 #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slach
requested changes
Jul 18, 2024
| @@ -14,6 +14,10 @@ jsonData, onSwitchToggle, onFieldChange, externalProps | |||
|
|
|||
| useEffect(() => { | |||
| const doRequest = async () => { | |||
| if (!jsonData.dataSourceUrl.startsWith('http://') && !jsonData.dataSourceUrl.startsWith('https://')) { | |||
There was a problem hiding this comment.
this is wrong fix IMHO, change approach
I requested check options only after press "Save & Test"
for example, if you press "use CORS" or "use POST"
and don't press "Save & Test" nothing shall happen
do you will make request for every press button in any control?
password for example?
username?
There was a problem hiding this comment.
@Slach Form itself works correctly and doesn't send checks before we perform save and test, the issue happens because we're fetching information for default fields:
There was a problem hiding this comment.
IMHO this solution is the correct one for a situation like this
There was a problem hiding this comment.
@lunaticusgreen
wrong behavior still not fixed
look detailed to
#587
Slach
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #595
fix #587