Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection settings should be not reactive, and check only when press save & test #587

Closed
antip00 opened this issue Jun 26, 2024 · 0 comments · Fixed by #598
Closed

connection settings should be not reactive, and check only when press save & test #587

antip00 opened this issue Jun 26, 2024 · 0 comments · Fixed by #598
Assignees
@lunaticusgreen
Milestone
3.2.2

Comments

@antip00
Copy link
Collaborator

antip00 commented Jun 26, 2024 •
edited by Slach
Loading

each key press in URL tries to fetch URL in browser, need to check how we control it, and allow changes only if "save & test" button pressed

Screenshot from 2024-06-26 14-29-39
@Slach Slach added this to the 3.2.2 milestone Jun 26, 2024
@Slach Slach changed the title url in connection settings should be not reactive connection settings should be not reactive, and check only when press save & test Jul 6, 2024
@lunaticusgreen lunaticusgreen mentioned this issue Jul 18, 2024
Merged
Slach added a commit that referenced this issue Jul 22, 2024
@Slach
Merge pull request #598 from Altinity/fix-595-587
d2edcc4 
Bugfixes #595 and #587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lunaticusgreen lunaticusgreen

Labels
None yet
Projects
None yet
Milestone
3.2.2
Development

Successfully merging a pull request may close this issue.

Bugfixes #595 and #587 Altinity/clickhouse-grafana
3 participants
@Slach @lunaticusgreen @antip00