Put all Fuse Stressbench operations in a new dir #14742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LuQQiu Please take a look. Thanks! |
LuQQiu
approved these changes
Dec 24, 2021
LuQQiu
reviewed
Dec 24, 2021
| @@ -138,6 +138,8 @@ public void prepare() throws Exception { | |||
| + "be at least the number of threads, preferably a multiple of it." | |||
| )); | |||
| } | |||
| // All test operations happen in mLocalpath/fuseIOStressBench | |||
| mParameters.mLocalPath = Paths.get(mParameters.mLocalPath, "fuseIOStressBench").toString(); | |||
There was a problem hiding this comment.
do we want to name the subfolder following the operation type to avoid conflicts?
but it's update to you
also, did we add cluster-id to the test path?
There was a problem hiding this comment.
Operation type you mean "Write", "LocalRead, "RemoteRead" and "ClusterRead"?
No we don't add cluster id to the test path. We add the job-worker id though
There was a problem hiding this comment.
we can keep the path for now and no need to worry about it
|
alluxio-bot, merge this please |
yyongycy
pushed a commit
to yyongycy/alluxio
that referenced
this pull request
Jan 6, 2022
We create a new dir `fuseIOStressBench` inside `localPath` and all files will be written and read inside this new directory. We can then avoid the case that the test files interfere with other files in Alluxio space. pr-link: Alluxio#14742 change-id: cid-b46d31eb5ea1eb39f93baa0a5165776f828ee9a6
flaming-archer
pushed a commit
to flaming-archer/alluxio
that referenced
this pull request
Sep 1, 2022
We create a new dir `fuseIOStressBench` inside `localPath` and all files will be written and read inside this new directory. We can then avoid the case that the test files interfere with other files in Alluxio space. pr-link: Alluxio#14742 change-id: cid-b46d31eb5ea1eb39f93baa0a5165776f828ee9a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create a new dir
fuseIOStressBenchinsidelocalPathand all files will be written and read inside this new directory. We can then avoid the case that the test files interfere with other files in Alluxio space.