Skip to content

Commit

Permalink
Do not fail github-actions even when archiving artifacts fails
Browse files Browse the repository at this point in the history
Uploading github-actions artifacts is extremely flaky. Just look at
actions/upload-artifact#84 (comment)
(Note the many +1 on the issue even after the issue has been closed.).

This tries to make sure that the test isn't marked as failure because
archiving the artifacts failed on some files.

pr-link: #12328
change-id: cid-72f6694761bfc3a88a62ca0422deee116779e6be
  • Loading branch information
bradyoo authored and alluxio-bot committed Nov 17, 2020
1 parent 6b3236a commit 1407c31
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/checkstyle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
timeout-minutes: 60

- name: Archive artifacts
continue-on-error: true
uses: actions/upload-artifact@v2
if: always()
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/java11_integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ jobs:
timeout-minutes: 60

- name: Archive artifacts
continue-on-error: true
uses: actions/upload-artifact@v2
if: always()
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/java11_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
timeout-minutes: 60

- name: Archive artifacts
continue-on-error: true
uses: actions/upload-artifact@v2
if: always()
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/java8_integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
timeout-minutes: 60

- name: Archive artifacts
continue-on-error: true
uses: actions/upload-artifact@v2
if: always()
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/java8_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
timeout-minutes: 60

- name: Archive artifacts
continue-on-error: true
uses: actions/upload-artifact@v2
if: always()
with:
Expand Down

0 comments on commit 1407c31

Please sign in to comment.