Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail github-actions even when archiving artifacts fails #12328

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

bradyoo
Copy link
Contributor

@bradyoo bradyoo commented Oct 16, 2020

Uploading github-actions artifacts is extremely flaky. Just look at actions/upload-artifact#84 (comment) (Note the many +1 on the issue even after the issue has been closed.).

This tries to make sure that the test isn't marked as failure because archiving the artifacts failed on some files.

@bradyoo
Copy link
Contributor Author

bradyoo commented Oct 16, 2020

@gpang Note that this had the intended effect of artifact archiving failing but the test succeeding because retry attempt #2 succeeded.

@bradyoo bradyoo requested a review from Xenorith October 16, 2020 16:18
@bradyoo
Copy link
Contributor Author

bradyoo commented Oct 16, 2020

@Xenorith

@bradyoo
Copy link
Contributor Author

bradyoo commented Oct 16, 2020

alluxio-bot, merge this please.

@alluxio-bot alluxio-bot merged commit 712a283 into Alluxio:master Oct 16, 2020
@LuQQiu
Copy link
Contributor

LuQQiu commented Nov 17, 2020

alluxio-bot, cherry-pick to branch-2.4 please

@LuQQiu
Copy link
Contributor

LuQQiu commented Nov 17, 2020

alluxio-bot, cherry-pick this to branch-2.4 please

alluxio-bot pushed a commit that referenced this pull request Nov 17, 2020
Uploading github-actions artifacts is extremely flaky. Just look at
actions/upload-artifact#84 (comment)
(Note the many +1 on the issue even after the issue has been closed.).

This tries to make sure that the test isn't marked as failure because
archiving the artifacts failed on some files.

pr-link: #12328
change-id: cid-72f6694761bfc3a88a62ca0422deee116779e6be
@alluxio-bot
Copy link
Contributor

Auto cherry-pick to branch branch-2.4 successfully opened PR: #12522

alluxio-bot added a commit that referenced this pull request Nov 17, 2020
Cherry-pick of existing commit.
orig-pr: #12328
orig-commit: 712a283
orig-commit-author: Bradley Yoo <[email protected]>

pr-link: #12522
change-id: cid-72f6694761bfc3a88a62ca0422deee116779e6be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants