Feature/thumbnail loading placeholder #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
approved these changes
Oct 11, 2024
| styles.fileThumbnail, | ||
| styles.thumbnailPlaceholder | ||
| )} | ||
| style={{ height: props.height, width: props.width }} |
There was a problem hiding this comment.
Should this default to being a square if one of the fields is present but not the other? Like so:
style={{ height: props.height || props.width, width: props.width || props.height }}
There was a problem hiding this comment.
resolved in 478fbd2
|
Currently has a visual bug where the loading box / spinner is misaligned. I tried recentering but somethings weird. |
aswallace
reviewed
Oct 15, 2024
aswallace
approved these changes
Oct 15, 2024
SeanLeRoy
reviewed
Oct 16, 2024
| let attempt = 0; | ||
| while (attempt < retries) { | ||
| try { | ||
| return await withTimeout(fn(), timeout); |
There was a problem hiding this comment.
What is the purpose of the timeout here. Does it help the callstack avoid getting overloaded somehow?
There was a problem hiding this comment.
From what i can tell some async requests in the zarr render dont register as failures, This just says if its taking too long count it as a failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to resolve #161 and add a loading state to thumbnails that we are rendering. In the course of this PR the following logic was added:
SCREENSHOTS
Small icon loading
Failed Zarr (top left corner)