-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade packages #15
Upgrade packages #15
Conversation
Looks like the mypy error on usings
|
… error that needs to be fixed on matplotlibs end
I read the There is a difference though: the commit I just pushed now gives all the colors an alpha channel (fully opaque). matplotlib.colormaps.get_cmap("Dark2").colors[7] == (0.4, 0.4, 0.4)
matplotlib.colormaps.get_cmap("Dark2")(7) == (0.4, 0.4, 0.4, 1.0) My reading of the code makes me think this shouldn't be a problem, since we're just passing the color to matplotlib, but it may be worth further attention @jcass11. |
Started by @pgarrison and picked up by @jcass11
Purpose
Main intent:
Other changes to fix mypy errors:
Testing
run_all_manuscript_workflows.py
ran without error, checked out a random set of figures and all looked correctnuc_morph_analysis/lib/preprocessing/save_datasets_for_quilt.py
ran without error but ran into memory issues loading and comparing outputsnuc_morph_analysis/lib/preprocessing/generate_main_manifest.py
ran without error and compared output to quilt, only difference is the existence of the parent IDs 71552 and 71115 which is expected)nuc_morph_analysis/lib/preprocessing/generate_perturbation_manifest.py
ran without error and compared output to quilt, both feeding control and perturbation manifests are unchangednuc_morph_analysis/lib/visualization/write_data_for_colorizer.py
lots of issues with memory error when not running with--noframes
but looking at the output files directly things look good (colony orientation is correct in images, timepoints in correct order, quick scan of values in jsons seem appropriate)