Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load all_baseline before subsetting #11

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

chantelleleveille
Copy link
Contributor

Our load dataset functions do not currently support loading subset colony datasets using the keys: "small", "medium", "large". Updated figure 1 workflows to load "all_baseline" before subsetting to a particular colony. This update makes sure figure1_dataset succeeds when running run_all_manuscript_workflows.py.

====== Successes ======
figure1_dataset (1927.0s) (48.0GB)
====== 1 succeeded  ======

A future PR could update the load dataset functions to work with the colony keys.

@jcass11
Copy link
Collaborator

jcass11 commented Jul 25, 2024

Thanks for addressing this ongoing error we've had! Testing by running pdm run run_all_manuscript_workflows.py --only figure1_dataset now

@jcass11
Copy link
Collaborator

jcass11 commented Jul 25, 2024

Thanks for addressing this ongoing error we've had! Testing by running pdm run run_all_manuscript_workflows.py --only figure1_dataset now

Workflow succeeded and figures look good!

====== Successes ======
figure1_dataset (1674.9s) (50.4GB)
====== 1 succeeded  ======

Copy link
Collaborator

@jcass11 jcass11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@pgarrison pgarrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A future PR could update the load dataset functions to work with the colony keys.

I'd love to see it but I also love that we are making small PRs like this to address one thing at a time!

@chantelleleveille chantelleleveille added this pull request to the merge queue Jul 25, 2024
Merged via the queue into bioRxiv-v1 with commit e2fb39e Jul 25, 2024
1 check passed
@chantelleleveille chantelleleveille deleted the run_all_wkfl branch July 25, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants