Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tables of analysis commands for every dataset #70

Merged
merged 5 commits into from
Dec 7, 2024

Conversation

pgarrison
Copy link
Collaborator

Purpose

Follow-up on @ritvikvasan's comment in #61 that we could use the same table format for run_features.py and run_analysis.py

Reviewing

Warning: I didn't run these commands myself! These are untested instructions.

@ritvikvasan and @fatwir please read these closely and check they are the same commands you used.

Copy link
Collaborator

@vianamp vianamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/USAGE.md Outdated Show resolved Hide resolved
docs/USAGE.md Outdated Show resolved Hide resolved
docs/USAGE.md Outdated Show resolved Hide resolved
docs/USAGE.md Outdated Show resolved Hide resolved
docs/USAGE.md Outdated Show resolved Hide resolved
docs/USAGE.md Outdated Show resolved Hide resolved
docs/USAGE.md Outdated Show resolved Hide resolved
@pgarrison pgarrison requested a review from ritvikvasan December 6, 2024 02:08
@fatwir
Copy link
Collaborator

fatwir commented Dec 6, 2024

LGTM!

Copy link
Collaborator

@ritvikvasan ritvikvasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@pgarrison pgarrison merged commit 9b8809b into main Dec 7, 2024
1 check passed
@pgarrison pgarrison deleted the analysis-command-tables branch December 7, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants