Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing volume config in terway.yml #9

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

BetaCat0
Copy link
Contributor

Fix missing volume config in terway.yml which will cause terway to panic.

@BSWANG
Copy link
Member

BSWANG commented Mar 25, 2019

LGTM
Thanks! @BetaCat0

@BSWANG BSWANG merged commit 4de1a32 into AliyunContainerService:master Mar 25, 2019
@BetaCat0
Copy link
Contributor Author

Hi guys, I also suggest that you could post the limitation of ENI allocation which mentioned in here, you know, it will raise an error like "xx Insufficient aliyun/eni" when you trying to claim ENI. Furthermore, how about add a trouble shooting part in readme 😀?

@BSWANG
Copy link
Member

BSWANG commented Mar 25, 2019

@BetaCat0 🙂 Yes, we should add trouble shooting section or document link in readme. I create an issue to trace this request #10.

@BetaCat0
Copy link
Contributor Author

This is gonna be nice. Thanks a lot.

@BetaCat0 BetaCat0 deleted the fix-missing-volume branch March 26, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants