Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] add up ensure service cidr config within daemonModeENIMultiIP, … #79

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

Komey
Copy link
Contributor

@Komey Komey commented Dec 18, 2019

add up ensure service cidr config within daemonModeENIMultiIP (eniIPVirtualTypeIPVlan needed)

https://github.com/AliyunContainerService/terway/blob/master/daemon/daemon.go#L241
https://github.com/AliyunContainerService/terway/blob/master/daemon/daemon.go#L620
https://github.com/AliyunContainerService/terway/blob/master/daemon/k8s.go#L74

while 
daemonMode == daemonModeENIMultiIP && config.ServiceCIDR ==""
panic
networkService.k8s.GetServiceCidr().String() 

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #79   +/-   ##
======================================
  Coverage    6.01%   6.01%           
======================================
  Files          31      31           
  Lines        4026    4026           
======================================
  Hits          242     242           
  Misses       3769    3769           
  Partials       15      15
Impacted Files Coverage Δ
daemon/k8s.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1123e7...9a00caa. Read the comment docs.

daemon/k8s.go Outdated Show resolved Hide resolved
@BSWANG BSWANG merged commit 161324c into AliyunContainerService:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants